<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns: always clean up the ns_codec<br><br>The f_clean_ns_codec() was introduced later to clean up the ns_codec<br>properly.<br><br>Change-Id: I7a84f75ebd1c68b3c0a6b55b8c49903c51dd6b92<br>---<br>M ns/NS_Tests.ttcn<br>1 file changed, 19 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn</span><br><span>index 105d397..8b321ff 100644</span><br><span>--- a/ns/NS_Tests.ttcn</span><br><span>+++ b/ns/NS_Tests.ttcn</span><br><span>@@ -131,6 +131,7 @@</span><br><span> </span><br><span>       setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> testcase TC_tx_reset_tx_alive() runs on RAW_Test_CT {</span><br><span>@@ -145,6 +146,7 @@</span><br><span> </span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> testcase TC_tx_reset_rx_alive() runs on RAW_Test_CT {</span><br><span>@@ -160,6 +162,7 @@</span><br><span> </span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.2.1 transmit a UNIT DATA over a BLOCKED NSVC when ttcn3 blocked it</span><br><span>@@ -227,6 +230,7 @@</span><br><span>         f_outgoing_ns_unblock();</span><br><span>     setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.2 tx unblock retries</span><br><span>@@ -254,6 +258,7 @@</span><br><span>       f_outgoing_ns_unblock();</span><br><span>     setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.2 block procedure</span><br><span>@@ -318,6 +323,7 @@</span><br><span> testcase TC_tx_block_by_vty() runs on RAW_Test_CT {</span><br><span>   tx_block_by_vty(30.0);</span><br><span>       f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.2 block precedure by vty and reset the NSVC.</span><br><span>@@ -336,6 +342,7 @@</span><br><span>       [] T.timeout { setverdict(pass); }</span><br><span>   }</span><br><span>    deactivate(d);</span><br><span style="color: hsl(120, 100%, 40%);">+        f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.4.1 ignore unexpected NS_ALIVE ACK */</span><br><span>@@ -347,6 +354,7 @@</span><br><span>      f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 NS_RESET with wrong nsei */</span><br><span>@@ -359,6 +367,7 @@</span><br><span>    f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 NS_RESET with wrong nsvci */</span><br><span>@@ -371,6 +380,7 @@</span><br><span>   f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 NS_RESET with wrong nsvci + nsei */</span><br><span>@@ -383,6 +393,7 @@</span><br><span>    f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 NS_RESET_ACK with wrong nsei */</span><br><span>@@ -395,6 +406,7 @@</span><br><span>        f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 NS_RESET_ACK with wrong nsvci */</span><br><span>@@ -407,6 +419,7 @@</span><br><span>       f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 NS_RESET_ACK with wrong nsvci + nsei */</span><br><span>@@ -419,6 +432,7 @@</span><br><span>        f_fails_except_reset();</span><br><span>      setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3.1 ignore unexpected NS_RESET_ACK after NS_RESET+ALIVE */</span><br><span>@@ -439,6 +453,7 @@</span><br><span>         f_ensure_no_ns(answer_alive := true, tout := 15.0);</span><br><span>  setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.3 NS_RESET retries */</span><br><span>@@ -460,6 +475,7 @@</span><br><span>      }</span><br><span> </span><br><span>        f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 behave RESET_ACK got dropped</span><br><span>@@ -493,6 +509,7 @@</span><br><span>         }</span><br><span> </span><br><span>        f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 7.4 test procedure for frame relay with a single nsvci */</span><br><span>@@ -526,10 +543,12 @@</span><br><span> </span><br><span> testcase TC_alive_retries_single_reset() runs on RAW_Test_CT {</span><br><span>    f_alive_retries_single(reset := true);</span><br><span style="color: hsl(120, 100%, 40%);">+        f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> testcase TC_alive_retries_single_no_resp() runs on RAW_Test_CT {</span><br><span>     f_alive_retries_single(reset := false);</span><br><span style="color: hsl(120, 100%, 40%);">+       f_clean_ns_codec();</span><br><span> }</span><br><span> </span><br><span> /* 48.016 SNS test cases */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353">change 25353</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7a84f75ebd1c68b3c0a6b55b8c49903c51dd6b92 </div>
<div style="display:none"> Gerrit-Change-Number: 25353 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>