Change in osmo-gbproxy[master]: gbproxy: Add comment, remove unused param in gbproxy_tlli_from_status...

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26010 )


Change subject: gbproxy: Add comment, remove unused param in gbproxy_tlli_from_status_pdu
......................................................................

gbproxy: Add comment, remove unused param in gbproxy_tlli_from_status_pdu

Change-Id: I8fc4c42c11ee38df80fbd316bbe6b1eb243b5323
---
M src/gb_proxy.c
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/10/26010/1

diff --git a/src/gb_proxy.c b/src/gb_proxy.c
index 5d9219d..18e0efb 100644
--- a/src/gb_proxy.c
+++ b/src/gb_proxy.c
@@ -989,7 +989,8 @@
 	return gbprox_relay2nse(msg, sgsn->nse, 0);
 }
 
-static int gbproxy_tlli_from_status_pdu(struct msgb *msg, struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx)
+/* Extract the TLLI from the PDU-in-error of the STATUS PDU (if available) */
+static int gbproxy_tlli_from_status_pdu(struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx)
 {
 	int rc;
 	int pdu_len = TLVP_LEN(&tp[0], BSSGP_IE_PDU_IN_ERROR);
@@ -1149,7 +1150,7 @@
 		LOGPNSE(nse, LOGL_NOTICE, "Rx STATUS cause=0x%02x(%s) ", cause,
 			bssgp_cause_str(cause));
 
-		if (gbproxy_tlli_from_status_pdu(msg, tp, &tlli, log_pfx) == 0)
+		if (gbproxy_tlli_from_status_pdu(tp, &tlli, log_pfx) == 0)
 			sgsn = gbproxy_select_sgsn(nse->cfg, &tlli);
 		else
 			sgsn = gbproxy_select_sgsn(nse->cfg, NULL);
@@ -1535,7 +1536,8 @@
 			return gbprox_relay2nse(msg, cell->bss_bvc->nse, 0);
 		}
 
-		if (gbproxy_tlli_from_status_pdu(msg, tp, &tlli, log_pfx) == 0) {
+		/* We can only forward this TLLI if it's in the cache (which only happens on suspend/resume) */
+		if (gbproxy_tlli_from_status_pdu(tp, &tlli, log_pfx) == 0) {
 			nse_peer = gbproxy_nse_by_tlli(cfg, tlli);
 			if (nse_peer)
 				return gbprox_relay2nse(msg, nse_peer, 0);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I8fc4c42c11ee38df80fbd316bbe6b1eb243b5323
Gerrit-Change-Number: 26010
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/0189bd03/attachment.htm>