<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26010">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Add comment, remove unused param in gbproxy_tlli_from_status_pdu<br><br>Change-Id: I8fc4c42c11ee38df80fbd316bbe6b1eb243b5323<br>---<br>M src/gb_proxy.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/10/26010/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index 5d9219d..18e0efb 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -989,7 +989,8 @@</span><br><span>       return gbprox_relay2nse(msg, sgsn->nse, 0);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int gbproxy_tlli_from_status_pdu(struct msgb *msg, struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx)</span><br><span style="color: hsl(120, 100%, 40%);">+/* Extract the TLLI from the PDU-in-error of the STATUS PDU (if available) */</span><br><span style="color: hsl(120, 100%, 40%);">+static int gbproxy_tlli_from_status_pdu(struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx)</span><br><span> {</span><br><span>    int rc;</span><br><span>      int pdu_len = TLVP_LEN(&tp[0], BSSGP_IE_PDU_IN_ERROR);</span><br><span>@@ -1149,7 +1150,7 @@</span><br><span>           LOGPNSE(nse, LOGL_NOTICE, "Rx STATUS cause=0x%02x(%s) ", cause,</span><br><span>                    bssgp_cause_str(cause));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-            if (gbproxy_tlli_from_status_pdu(msg, tp, &tlli, log_pfx) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+           if (gbproxy_tlli_from_status_pdu(tp, &tlli, log_pfx) == 0)</span><br><span>                       sgsn = gbproxy_select_sgsn(nse->cfg, &tlli);</span><br><span>          else</span><br><span>                         sgsn = gbproxy_select_sgsn(nse->cfg, NULL);</span><br><span>@@ -1535,7 +1536,8 @@</span><br><span>                       return gbprox_relay2nse(msg, cell->bss_bvc->nse, 0);</span><br><span>           }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           if (gbproxy_tlli_from_status_pdu(msg, tp, &tlli, log_pfx) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+         /* We can only forward this TLLI if it's in the cache (which only happens on suspend/resume) */</span><br><span style="color: hsl(120, 100%, 40%);">+           if (gbproxy_tlli_from_status_pdu(tp, &tlli, log_pfx) == 0) {</span><br><span>                     nse_peer = gbproxy_nse_by_tlli(cfg, tlli);</span><br><span>                   if (nse_peer)</span><br><span>                                return gbprox_relay2nse(msg, nse_peer, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26010">change 26010</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26010"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8fc4c42c11ee38df80fbd316bbe6b1eb243b5323 </div>
<div style="display:none"> Gerrit-Change-Number: 26010 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>