Change in osmo-gbproxy[master]: gbproxy: Add comment, improve log message in gbproxy_tlli_from_status...

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25983 )


Change subject: gbproxy: Add comment, improve log message in gbproxy_tlli_from_status_pdu
......................................................................

gbproxy: Add comment, improve log message in gbproxy_tlli_from_status_pdu

Change-Id: Idcd2742f451ba5ae79f62395e033924782336cac
---
M src/gb_proxy.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/83/25983/1

diff --git a/src/gb_proxy.c b/src/gb_proxy.c
index 1e8bc96..5c2d5bb 100644
--- a/src/gb_proxy.c
+++ b/src/gb_proxy.c
@@ -997,6 +997,7 @@
 	struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data;
 	struct tlv_parsed tp_inner[2];
 
+	/* TODO: Parse partial messages as well */
 	rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp_inner, ARRAY_SIZE(tp_inner), bgph->pdu_type, bgph->data,
 				 pdu_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx);
 
@@ -1111,16 +1112,19 @@
 		struct gbproxy_sgsn *sgsn;
 		/* Check if the status needs to be terminated locally */
 		uint8_t cause = *TLVP_VAL(&tp[0], BSSGP_IE_CAUSE);
+
 		if (cause == BSSGP_CAUSE_UNKNOWN_BVCI || cause == BSSGP_CAUSE_BVCI_BLOCKED) {
 			/* Log and handle locally */
 			ptp_bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI));
-			LOGP(DGPRS, LOGL_ERROR, "%s Rx STATUS with cause %s for PtP-BVC %05u\n", log_pfx,
+			LOGPNSE(nse, LOGL_ERROR, "Rx STATUS cause=0x%02x(%s) for PtP-BVC %05u\n", cause,
 				bssgp_cause_str(cause), ptp_bvci);
 			/* FIXME: Remove/block our BVC if present? */
 			break;
 		}
 
-		LOGP(DGPRS, LOGL_INFO, "Forwarding STATUS with cause %s\n", bssgp_cause_str(cause));
+		LOGPNSE(nse, LOGL_NOTICE, "Rx STATUS cause=0x%02x(%s) ", cause,
+			bssgp_cause_str(cause));
+
 		if (gbproxy_tlli_from_status_pdu(msg, tp, &tlli, log_pfx) == 0)
 			sgsn = gbproxy_select_sgsn(nse->cfg, &tlli);
 		else

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25983
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Idcd2742f451ba5ae79f62395e033924782336cac
Gerrit-Change-Number: 25983
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211027/c5f2f11d/attachment.htm>