<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/25983">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Add comment, improve log message in gbproxy_tlli_from_status_pdu<br><br>Change-Id: Idcd2742f451ba5ae79f62395e033924782336cac<br>---<br>M src/gb_proxy.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/83/25983/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index 1e8bc96..5c2d5bb 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -997,6 +997,7 @@</span><br><span>       struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data;</span><br><span>         struct tlv_parsed tp_inner[2];</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    /* TODO: Parse partial messages as well */</span><br><span>   rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp_inner, ARRAY_SIZE(tp_inner), bgph->pdu_type, bgph->data,</span><br><span>                              pdu_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx);</span><br><span> </span><br><span>@@ -1111,16 +1112,19 @@</span><br><span>               struct gbproxy_sgsn *sgsn;</span><br><span>           /* Check if the status needs to be terminated locally */</span><br><span>             uint8_t cause = *TLVP_VAL(&tp[0], BSSGP_IE_CAUSE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>             if (cause == BSSGP_CAUSE_UNKNOWN_BVCI || cause == BSSGP_CAUSE_BVCI_BLOCKED) {</span><br><span>                        /* Log and handle locally */</span><br><span>                         ptp_bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI));</span><br><span style="color: hsl(0, 100%, 40%);">-                   LOGP(DGPRS, LOGL_ERROR, "%s Rx STATUS with cause %s for PtP-BVC %05u\n", log_pfx,</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOGPNSE(nse, LOGL_ERROR, "Rx STATUS cause=0x%02x(%s) for PtP-BVC %05u\n", cause,</span><br><span>                           bssgp_cause_str(cause), ptp_bvci);</span><br><span>                   /* FIXME: Remove/block our BVC if present? */</span><br><span>                        break;</span><br><span>               }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DGPRS, LOGL_INFO, "Forwarding STATUS with cause %s\n", bssgp_cause_str(cause));</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGPNSE(nse, LOGL_NOTICE, "Rx STATUS cause=0x%02x(%s) ", cause,</span><br><span style="color: hsl(120, 100%, 40%);">+                     bssgp_cause_str(cause));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>           if (gbproxy_tlli_from_status_pdu(msg, tp, &tlli, log_pfx) == 0)</span><br><span>                  sgsn = gbproxy_select_sgsn(nse->cfg, &tlli);</span><br><span>          else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/25983">change 25983</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/25983"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idcd2742f451ba5ae79f62395e033924782336cac </div>
<div style="display:none"> Gerrit-Change-Number: 25983 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>