Change in osmo-bts[master]: [overpower] scheduler: handle {sacch, facch}_enabled flags

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25898 )

Change subject: [overpower] scheduler: handle {sacch,facch}_enabled flags
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/25898/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25898/1/src/common/scheduler.c@1310 
PS1, Line 1310: 	 || (lchan->top_acch_cap.facch_enabled && br->flags & TRX_BR_F_FACCH)) {
this way of writting the || before the initial "(" looks wrong to me. Do it:
"""
	if ((lchan->top_acch_cap.sacch_enabled && desc->link_id == LID_SACCH) ||
	    (lchan->top_acch_cap.facch_enabled && br->flags & TRX_BR_F_FACCH))
"""

Or what I call Neel's style: ;)
"""
	if ((lchan->top_acch_cap.sacch_enabled && desc->link_id == LID_SACCH)
	    || (lchan->top_acch_cap.facch_enabled && br->flags & TRX_BR_F_FACCH))
"""



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iaaab675a20bbefece832d913963c8c5ae32ff80c
Gerrit-Change-Number: 25898
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Oct 2021 13:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211022/07db5d1f/attachment.htm>