<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25898">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25898/1/src/common/scheduler.c">File src/common/scheduler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25898/1/src/common/scheduler.c@1310">Patch Set #1, Line 1310:</a> <code style="font-family:monospace,monospace">         || (lchan->top_acch_cap.facch_enabled && br->flags & TRX_BR_F_FACCH)) {</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">this way of writting the || before the initial "(" looks wrong to me. Do it:<br>"""<br>     if ((lchan->top_acch_cap.sacch_enabled && desc->link_id == LID_SACCH) ||<br>            (lchan->top_acch_cap.facch_enabled && br->flags & TRX_BR_F_FACCH))<br>"""</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Or what I call Neel's style: ;)<br>"""<br> if ((lchan->top_acch_cap.sacch_enabled && desc->link_id == LID_SACCH)<br>       || (lchan->top_acch_cap.facch_enabled && br->flags & TRX_BR_F_FACCH))<br>"""</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25898">change 25898</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25898"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaaab675a20bbefece832d913963c8c5ae32ff80c </div>
<div style="display:none"> Gerrit-Change-Number: 25898 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Oct 2021 13:16:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>