Change in osmo-iuh[master]: RFC: Add lib prefix to structs with duplicated names

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 21 17:16:54 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/25888 )

Change subject: RFC: Add lib prefix to structs with duplicated names
......................................................................


Patch Set 2:

We really need to regenerate all the code adding per-lib prefixes per lib (I think as1nc supports passing a prefix).

Is it documented somewhere how to regenerate the code?

There's even enums and enum fields colliding:
"""
In file included from /build/new/out/include/osmocom/ranap/RANAP_GA-Point.h:14,
                 from /build/new/out/include/osmocom/ranap/RANAP_GeographicalArea.h:14,
                 from /build/new/out/include/osmocom/ranap/RANAP_AreaIdentity.h:15,
                 from /build/new/out/include/osmocom/ranap/ranap_common.h:29,
                 from /git/osmo-hnodeb/src/osmo-hnodeb/main.c:69:
/build/new/out/include/osmocom/ranap/RANAP_GeographicalCoordinates.h:24:14: error: redeclaration of ‘enum latitudeSign’
   24 | typedef enum latitudeSign {
      |              ^~~~~~~~~~~~
In file included from /build/new/out/include/osmocom/hnbap/hnbap_common.h:41,
                 from /git/osmo-hnodeb/src/osmo-hnodeb/main.c:54:
/build/new/out/include/osmocom/hnbap/GeographicalCoordinates.h:24:14: note: originally defined here
   24 | typedef enum latitudeSign {
      |              ^~~~~~~~~~~~
In file included from /build/new/out/include/osmocom/ranap/RANAP_GA-Point.h:14,
                 from /build/new/out/include/osmocom/ranap/RANAP_GeographicalArea.h:14,
                 from /build/new/out/include/osmocom/ranap/RANAP_AreaIdentity.h:15,
                 from /build/new/out/include/osmocom/ranap/ranap_common.h:29,
                 from /git/osmo-hnodeb/src/osmo-hnodeb/main.c:69:
/build/new/out/include/osmocom/ranap/RANAP_GeographicalCoordinates.h:25:9: error: redeclaration of enumerator ‘latitudeSign_north’
   25 |         latitudeSign_north      = 0,
      |         ^~~~~~~~~~~~~~~~~~
In file included from /build/new/out/include/osmocom/hnbap/hnbap_common.h:41,
                 from /git/osmo-hnodeb/src/osmo-hnodeb/main.c:54:
/build/new/out/include/osmocom/hnbap/GeographicalCoordinates.h:25:9: note: previous definition of ‘latitudeSign_north’ with type ‘enum latitudeSign’
   25 |         latitudeSign_north      = 0,
      |         ^~~~~~~~~~~~~~~~~~
""""


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I552fc028c7d08c880fdb844ece75816602c5bb67
Gerrit-Change-Number: 25888
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 21 Oct 2021 17:16:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211021/68eec031/attachment.htm>


More information about the gerrit-log mailing list