Change in osmo-iuh[master]: RFC: Add lib prefix to structs with duplicated names

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 21 16:57:10 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-iuh/+/25888

to look at the new patch set (#2).

Change subject: RFC: Add lib prefix to structs with duplicated names
......................................................................

RFC: Add lib prefix to structs with duplicated names

Otherwise it's impossible to include eg. rua/*.h and ranap/*.h since
they will collision and gcc will error.

Following commands are used to generate this patch:
"""
for t in hnbap ranap rua sabp; do ag -l "struct Member" include/osmocom/$t src/$t/ | xargs sed -i "s/struct Member/struct ${t}_Member/g"; done
for t in hnbap ranap rua sabp; do ag -l "struct errorIndication_ies" include/osmocom/$t src/$t/ | xargs sed -i "s/struct errorIndication_ies/struct ${t}_errorIndication_ies/g"; done
for t in hnbap ranap rua sabp; do ag -l "struct directTransfer_ies" include/osmocom/$t src/$t/ | xargs sed -i "s/struct directTransfer_ies/struct ${t}_directTransfer_ies/g"; done
for t in hnbap ranap rua sabp; do ag -l "struct privateMessage_ies" include/osmocom/$t src/$t/ | xargs sed -i "s/struct privateMessage_ies/struct ${t}_privateMessage_ies/g"; done
"""

Change-Id: I552fc028c7d08c880fdb844ece75816602c5bb67
---
M include/osmocom/hnbap/CriticalityDiagnostics-IE-List.h
M include/osmocom/hnbap/ErrorIndication.h
M include/osmocom/hnbap/PrivateMessage.h
M include/osmocom/ranap/RANAP_AuthorisedPLMNs.h
M include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h
M include/osmocom/ranap/RANAP_DataVolumeList.h
M include/osmocom/ranap/RANAP_DirectTransfer.h
M include/osmocom/ranap/RANAP_EUTRANFrequencies.h
M include/osmocom/ranap/RANAP_ErrorIndication.h
M include/osmocom/ranap/RANAP_GA-Polygon.h
M include/osmocom/ranap/RANAP_JoinedMBMSBearerService-IEs.h
M include/osmocom/ranap/RANAP_LA-LIST.h
M include/osmocom/ranap/RANAP_LeftMBMSBearerService-IEs.h
M include/osmocom/ranap/RANAP_MessageStructure.h
M include/osmocom/ranap/RANAP_PLMNs-in-shared-network.h
M include/osmocom/ranap/RANAP_PrivateMessage.h
M include/osmocom/ranap/RANAP_RABDataVolumeReport.h
M include/osmocom/ranap/RANAP_RABParametersList.h
M include/osmocom/ranap/RANAP_UnsuccessfulLinking-IEs.h
M include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h
M include/osmocom/rua/RUA_DirectTransfer.h
M include/osmocom/rua/RUA_ErrorIndication.h
M include/osmocom/rua/RUA_PrivateMessage.h
M include/osmocom/sabp/SABP_CriticalityDiagnostics-IE-List.h
M include/osmocom/sabp/SABP_MessageStructure.h
M src/hnbap/CriticalityDiagnostics-IE-List.c
M src/hnbap/ErrorIndication.c
M src/hnbap/PrivateMessage.c
M src/ranap/RANAP_AuthorisedPLMNs.c
M src/ranap/RANAP_CriticalityDiagnostics-IE-List.c
M src/ranap/RANAP_DataVolumeList.c
M src/ranap/RANAP_DirectTransfer.c
M src/ranap/RANAP_EUTRANFrequencies.c
M src/ranap/RANAP_ErrorIndication.c
M src/ranap/RANAP_GA-Polygon.c
M src/ranap/RANAP_JoinedMBMSBearerService-IEs.c
M src/ranap/RANAP_LA-LIST.c
M src/ranap/RANAP_LeftMBMSBearerService-IEs.c
M src/ranap/RANAP_MessageStructure.c
M src/ranap/RANAP_PLMNs-in-shared-network.c
M src/ranap/RANAP_PrivateMessage.c
M src/ranap/RANAP_RABDataVolumeReport.c
M src/ranap/RANAP_RABParametersList.c
M src/ranap/RANAP_UnsuccessfulLinking-IEs.c
M src/rua/RUA_CriticalityDiagnostics-IE-List.c
M src/rua/RUA_DirectTransfer.c
M src/rua/RUA_ErrorIndication.c
M src/rua/RUA_PrivateMessage.c
M src/sabp/SABP_CriticalityDiagnostics-IE-List.c
M src/sabp/SABP_MessageStructure.c
50 files changed, 130 insertions(+), 130 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/88/25888/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I552fc028c7d08c880fdb844ece75816602c5bb67
Gerrit-Change-Number: 25888
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211021/12c7ebeb/attachment.htm>


More information about the gerrit-log mailing list