Change in osmo-bsc[master]: stat: add bts.N.num_trx:total

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25506 )

Change subject: stat: add bts.N.num_trx:total
......................................................................

stat: add bts.N.num_trx:total

This is similar to bsc.0.num_trx:total but per single BTS.

Related: SYS#5542
Related: I5be1cb470930354c4561cbed301bc50a32484ed9 (osmo-ttcn3-hacks)
Depends: I137992a5479fc39bbceb6c6c2af9c227bd33b39b (libosmocore)
Change-Id: I283d38e7a8c032e274a5bd2fa150ec2c9a7157b4
---
M TODO-RELEASE
M include/osmocom/bsc/bts.h
M src/osmo-bsc/bsc_stats.c
M src/osmo-bsc/bts.c
4 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 90ec16b..89bc1cb 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -15,3 +15,4 @@
 libosmosgsm     >1.5.1          needs GSM_PCHAN_OSMO_DYN
 libosmocore     >1.5.1          RSL_IPAC_EIE_OSMO*, struct osmo_preproc_*
 libosmocore	>1.5.1		needs osmo_str_to_int()
+libosmocore	>1.5.1		needs new osmo_stat_item implementation (omits FIFO size for stat item)
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 5ff798b..f09d068 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -175,6 +175,7 @@
 	BTS_STAT_RSL_CONNECTED,
 	BTS_STAT_LCHAN_BORKEN,
 	BTS_STAT_TS_BORKEN,
+	BTS_STAT_NUM_TRX_TOTAL,
 };
 
 extern const struct osmo_stat_item_desc bts_stat_desc[];
diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c
index f33e6c8..3b96fed 100644
--- a/src/osmo-bsc/bsc_stats.c
+++ b/src/osmo-bsc/bsc_stats.c
@@ -162,6 +162,9 @@
 				trx_rsl_connected++;
 		}
 
+		osmo_stat_item_set(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_NUM_TRX_TOTAL),
+				   num_trx);
+
 		num_trx_total += num_trx;
 		trx_rsl_connected_total += trx_rsl_connected;
 
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 3f782c1..4bda721 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -1311,6 +1311,10 @@
 		{ "ts_borken",
 		  "Number of timeslots in the BORKEN state",
 		  "", 16, 0 },
+	[BTS_STAT_NUM_TRX_TOTAL] = \
+		{ "num_trx:total",
+		  "Number of configured TRX in this BTS",
+		  "" },
 };
 
 const struct osmo_stat_item_group_desc bts_statg_desc = {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25506
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I283d38e7a8c032e274a5bd2fa150ec2c9a7157b4
Gerrit-Change-Number: 25506
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211013/ddf2cc02/attachment.htm>