<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25506">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stat: add bts.N.num_trx:total<br><br>This is similar to bsc.0.num_trx:total but per single BTS.<br><br>Related: SYS#5542<br>Related: I5be1cb470930354c4561cbed301bc50a32484ed9 (osmo-ttcn3-hacks)<br>Depends: I137992a5479fc39bbceb6c6c2af9c227bd33b39b (libosmocore)<br>Change-Id: I283d38e7a8c032e274a5bd2fa150ec2c9a7157b4<br>---<br>M TODO-RELEASE<br>M include/osmocom/bsc/bts.h<br>M src/osmo-bsc/bsc_stats.c<br>M src/osmo-bsc/bts.c<br>4 files changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 90ec16b..89bc1cb 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -15,3 +15,4 @@</span><br><span> libosmosgsm     >1.5.1          needs GSM_PCHAN_OSMO_DYN</span><br><span> libosmocore     >1.5.1          RSL_IPAC_EIE_OSMO*, struct osmo_preproc_*</span><br><span> libosmocore   >1.5.1               needs osmo_str_to_int()</span><br><span style="color: hsl(120, 100%, 40%);">+libosmocore    >1.5.1               needs new osmo_stat_item implementation (omits FIFO size for stat item)</span><br><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index 5ff798b..f09d068 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -175,6 +175,7 @@</span><br><span>       BTS_STAT_RSL_CONNECTED,</span><br><span>      BTS_STAT_LCHAN_BORKEN,</span><br><span>       BTS_STAT_TS_BORKEN,</span><br><span style="color: hsl(120, 100%, 40%);">+   BTS_STAT_NUM_TRX_TOTAL,</span><br><span> };</span><br><span> </span><br><span> extern const struct osmo_stat_item_desc bts_stat_desc[];</span><br><span>diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c</span><br><span>index f33e6c8..3b96fed 100644</span><br><span>--- a/src/osmo-bsc/bsc_stats.c</span><br><span>+++ b/src/osmo-bsc/bsc_stats.c</span><br><span>@@ -162,6 +162,9 @@</span><br><span>                             trx_rsl_connected++;</span><br><span>                 }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         osmo_stat_item_set(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_NUM_TRX_TOTAL),</span><br><span style="color: hsl(120, 100%, 40%);">+                             num_trx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>               num_trx_total += num_trx;</span><br><span>            trx_rsl_connected_total += trx_rsl_connected;</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index 3f782c1..4bda721 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -1311,6 +1311,10 @@</span><br><span>              { "ts_borken",</span><br><span>               "Number of timeslots in the BORKEN state",</span><br><span>                 "", 16, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+      [BTS_STAT_NUM_TRX_TOTAL] = \</span><br><span style="color: hsl(120, 100%, 40%);">+          { "num_trx:total",</span><br><span style="color: hsl(120, 100%, 40%);">+            "Number of configured TRX in this BTS",</span><br><span style="color: hsl(120, 100%, 40%);">+             "" },</span><br><span> };</span><br><span> </span><br><span> const struct osmo_stat_item_group_desc bts_statg_desc = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25506">change 25506</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25506"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I283d38e7a8c032e274a5bd2fa150ec2c9a7157b4 </div>
<div style="display:none"> Gerrit-Change-Number: 25506 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>