Change in osmo-bts[master]: trx_provision_fsm: Drop impossible paths

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25678 )

Change subject: trx_provision_fsm: Drop impossible paths
......................................................................

trx_provision_fsm: Drop impossible paths

config.enabled is always true in that state. Hence, those paths can be
securely dropped since only add confusion.

Change-Id: Icf00c52e61ddedd8e32eb37223cea5686005e6a3
---
M src/osmo-bts-trx/trx_provision_fsm.c
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  neels: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c
index 758789d..4ea6758 100644
--- a/src/osmo-bts-trx/trx_provision_fsm.c
+++ b/src/osmo-bts-trx/trx_provision_fsm.c
@@ -588,15 +588,10 @@
 	switch (event) {
 	case TRX_PROV_EV_CLOSE:
 		/* power off transceiver, if not already */
-		if (l1h->config.enabled) {
-			if (pinst->num == 0 && plink->u.osmotrx.powered && !plink->u.osmotrx.poweronoff_sent) {
+		if (pinst->num == 0 && plink->u.osmotrx.powered && !plink->u.osmotrx.poweronoff_sent) {
 				trx_if_cmd_poweroff(l1h, l1if_poweronoff_cb);
 				plink->u.osmotrx.poweronoff_sent = true;
-			}
-		} else if (!pinst->phy_link->u.osmotrx.poweronoff_sent) {
-			bts_model_trx_close_cb(pinst->trx, 0);
-		} /* else: poweroff in progress, cb will be called upon TRXC RSP */
-
+		}
 		trx_prov_fsm_state_chg(fi, TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF);
 		break;
 	case TRX_PROV_EV_CFG_TS:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icf00c52e61ddedd8e32eb37223cea5686005e6a3
Gerrit-Change-Number: 25678
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/c48d34d9/attachment.htm>