<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25678">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  neels: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_provision_fsm: Drop impossible paths<br><br>config.enabled is always true in that state. Hence, those paths can be<br>securely dropped since only add confusion.<br><br>Change-Id: Icf00c52e61ddedd8e32eb37223cea5686005e6a3<br>---<br>M src/osmo-bts-trx/trx_provision_fsm.c<br>1 file changed, 2 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>index 758789d..4ea6758 100644</span><br><span>--- a/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>+++ b/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>@@ -588,15 +588,10 @@</span><br><span>   switch (event) {</span><br><span>     case TRX_PROV_EV_CLOSE:</span><br><span>              /* power off transceiver, if not already */</span><br><span style="color: hsl(0, 100%, 40%);">-             if (l1h->config.enabled) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   if (pinst->num == 0 && plink->u.osmotrx.powered && !plink->u.osmotrx.poweronoff_sent) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (pinst->num == 0 && plink->u.osmotrx.powered && !plink->u.osmotrx.poweronoff_sent) {</span><br><span>                             trx_if_cmd_poweroff(l1h, l1if_poweronoff_cb);</span><br><span>                                plink->u.osmotrx.poweronoff_sent = true;</span><br><span style="color: hsl(0, 100%, 40%);">-                     }</span><br><span style="color: hsl(0, 100%, 40%);">-               } else if (!pinst->phy_link->u.osmotrx.poweronoff_sent) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 bts_model_trx_close_cb(pinst->trx, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-               } /* else: poweroff in progress, cb will be called upon TRXC RSP */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>            trx_prov_fsm_state_chg(fi, TRX_PROV_ST_OPEN_WAIT_POWEROFF_CNF);</span><br><span>              break;</span><br><span>       case TRX_PROV_EV_CFG_TS:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25678">change 25678</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25678"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icf00c52e61ddedd8e32eb37223cea5686005e6a3 </div>
<div style="display:none"> Gerrit-Change-Number: 25678 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>