Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 )

Change subject: hnb: Introduce HNB_Tests testsuite
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn 
File library/Iuh_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn@35 
PS3, Line 35:   encode "PER";
you can even drop the PER encoding, as we don't encode/decode a Iuh_PDU anywhere, right?  We just create it to pass it around a port between two components, but don't receive/transmit it over a socket?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn@38 
PS3, Line 38: } with { encode "RAW" variant "BYTEORDER(first)" };
that then can also go, as

a) the only type defined overrides it with PER anyway
b) we don't expect to encode/decode any of this?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7
Gerrit-Change-Number: 26336
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 23 Nov 2021 14:39:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211123/bbc90db7/attachment.htm>