<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn">File library/Iuh_Types.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn@35">Patch Set #3, Line 35:</a> <code style="font-family:monospace,monospace">  encode "PER";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">you can even drop the PER encoding, as we don't encode/decode a Iuh_PDU anywhere, right?  We just create it to pass it around a port between two components, but don't receive/transmit it over a socket?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn@38">Patch Set #3, Line 38:</a> <code style="font-family:monospace,monospace">} with { encode "RAW" variant "BYTEORDER(first)" };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that then can also go, as</p><p style="white-space: pre-wrap; word-wrap: break-word;">a) the only type defined overrides it with PER anyway<br>b) we don't expect to encode/decode any of this?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336">change 26336</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 </div>
<div style="display:none"> Gerrit-Change-Number: 26336 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Nov 2021 14:39:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>