Change in pysim[master]: cards: select_adf_by_aid: split off aid completion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Nov 16 18:12:13 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26280 )

Change subject: cards: select_adf_by_aid: split off aid completion
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py@282 
PS4, Line 282: 	def _get_aid(adf="usim"):
Missing type definition (not critical):

  -> str


https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py@291 
PS4, Line 291: 	def _complete_aid(self, aid):
Same here:

  -> str



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86
Gerrit-Change-Number: 26280
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Nov 2021 18:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211116/9c6b216a/attachment.htm>


More information about the gerrit-log mailing list