<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/pysim/+/26280">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py">File pySim/cards.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py@282">Patch Set #4, Line 282:</a> <code style="font-family:monospace,monospace">        def _get_aid(adf="usim"):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Missing type definition (not critical):</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  -> str</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py@291">Patch Set #4, Line 291:</a> <code style="font-family:monospace,monospace">       def _complete_aid(self, aid):</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  -> str</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/26280">change 26280</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/26280"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 </div>
<div style="display:none"> Gerrit-Change-Number: 26280 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Nov 2021 18:12:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>