Change in osmo-ttcn3-hacks[master]: BTS_Tests: make TC_pcu_interf_ind more stable

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 )


Change subject: BTS_Tests: make TC_pcu_interf_ind more stable
......................................................................

BTS_Tests: make TC_pcu_interf_ind more stable

The first interference report may contain unreliable values, so we
ignore it and start the actual matching only after receiving it.

Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf
Related: SYS#5313
---
M bts/BTS_Tests.ttcn
1 file changed, 12 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/26196/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 754516b..143671c 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -6067,6 +6067,7 @@
 	var template PCUIF_Message tr_interf_ind;
 	var template PCUIF_interf ts_interf;
 	var integer interf_ind_num := 0;
+	var boolean first := true;
 	var PCUIF_send_data sd;
 	timer T;
 
@@ -6091,16 +6092,17 @@
 		interf := ts_interf
 	);
 
-	/* 4 SACCH periods => 4 reports (plus some guard time) */
-	var float Tval := int2float(4 * 480) / 1000.0 + 0.5;
-
-	/* Let it some time to stabilize */
-	f_sleep(0.5);
-	PCU.clear;
-
-	T.start(Tval);
+	T.start(0.480 * 1.5);
 	alt {
-	[] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd {
+	/* The first interference report may contain unreliable values, so we ignore it */
+	[first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) {
+		/* 4 SACCH periods => 4 reports (plus some guard time) */
+		T.start(0.480 * 4.0 + 0.480 / 2.0);
+		first := false;
+		repeat;
+		}
+	/* Subsequent interference reports shall match our expectations */
+	[not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd {
 		/* Check TDMA frame number period */
 		if (sd.data.u.interf_ind.fn mod 104 != 0) {
 			setverdict(fail, "Odd TDMA frame number := ",
@@ -6110,7 +6112,7 @@
 		if (interf_ind_num < 4)
 			{ repeat; }
 		}
-	[] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd {
+	[not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd {
 		setverdict(fail, "Received unexpected interference report: ", sd.data);
 		}
 	[] PCU.receive { repeat; }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf
Gerrit-Change-Number: 26196
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/b220a92a/attachment.htm>