<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: make TC_pcu_interf_ind more stable<br><br>The first interference report may contain unreliable values, so we<br>ignore it and start the actual matching only after receiving it.<br><br>Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf<br>Related: SYS#5313<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 12 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/26196/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 754516b..143671c 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -6067,6 +6067,7 @@</span><br><span>       var template PCUIF_Message tr_interf_ind;</span><br><span>    var template PCUIF_interf ts_interf;</span><br><span>         var integer interf_ind_num := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+      var boolean first := true;</span><br><span>   var PCUIF_send_data sd;</span><br><span>      timer T;</span><br><span> </span><br><span>@@ -6091,16 +6092,17 @@</span><br><span>               interf := ts_interf</span><br><span>  );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* 4 SACCH periods => 4 reports (plus some guard time) */</span><br><span style="color: hsl(0, 100%, 40%);">-    var float Tval := int2float(4 * 480) / 1000.0 + 0.5;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    /* Let it some time to stabilize */</span><br><span style="color: hsl(0, 100%, 40%);">-     f_sleep(0.5);</span><br><span style="color: hsl(0, 100%, 40%);">-   PCU.clear;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      T.start(Tval);</span><br><span style="color: hsl(120, 100%, 40%);">+        T.start(0.480 * 1.5);</span><br><span>        alt {</span><br><span style="color: hsl(0, 100%, 40%);">-   [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd {</span><br><span style="color: hsl(120, 100%, 40%);">+     /* The first interference report may contain unreliable values, so we ignore it */</span><br><span style="color: hsl(120, 100%, 40%);">+    [first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) {</span><br><span style="color: hsl(120, 100%, 40%);">+           /* 4 SACCH periods => 4 reports (plus some guard time) */</span><br><span style="color: hsl(120, 100%, 40%);">+          T.start(0.480 * 4.0 + 0.480 / 2.0);</span><br><span style="color: hsl(120, 100%, 40%);">+           first := false;</span><br><span style="color: hsl(120, 100%, 40%);">+               repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Subsequent interference reports shall match our expectations */</span><br><span style="color: hsl(120, 100%, 40%);">+    [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd {</span><br><span>           /* Check TDMA frame number period */</span><br><span>                 if (sd.data.u.interf_ind.fn mod 104 != 0) {</span><br><span>                  setverdict(fail, "Odd TDMA frame number := ",</span><br><span>@@ -6110,7 +6112,7 @@</span><br><span>              if (interf_ind_num < 4)</span><br><span>                   { repeat; }</span><br><span>          }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd {</span><br><span style="color: hsl(120, 100%, 40%);">+ [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd {</span><br><span>               setverdict(fail, "Received unexpected interference report: ", sd.data);</span><br><span>            }</span><br><span>    [] PCU.receive { repeat; }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196">change 26196</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf </div>
<div style="display:none"> Gerrit-Change-Number: 26196 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>