This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24421 ) Change subject: change bs_power to bs_power_db ...................................................................... Patch Set 6: (5 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6//COMMIT_MSG@9 PS6, Line 9: dBm Should be dB, because it's relative to the full power, not Milliwatt. https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6//COMMIT_MSG@10 PS6, Line 10: dBm Same here and below. https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6/src/osmo-bsc/abis_rsl.c@1040 PS6, Line 1040: ddBm dB https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6/src/osmo-bsc/abis_rsl.c@1129 PS6, Line 1129: bs_power_enc I would use: const uint8_t bs_power_enc = *TLVP_VAL(&tp, RSL_IE_BS_POWER); but this is not critical. https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6/src/osmo-bsc/abis_rsl.c@1130 PS6, Line 1130: bs_power_enc Ideally, we should apply a mask here: (bs_power_enc & 0x0f) * 2; because the 4 MSB bits may contain flags (FPC, EPC). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I229db1d6bcf532af95aff56b2ad18b5ed9d81616 Gerrit-Change-Number: 24421 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 27 May 2021 14:38:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/0b1db970/attachment.htm>