Change in osmo-bsc[master]: change bs_power to bs_power_db

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 27 10:33:58 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24421 )

Change subject: change bs_power to bs_power_db
......................................................................


Patch Set 6:

(1 comment)

I'm not really sure we really gain something with this patch, specially since ms_power is probably also stored the same way and you are then leaving each one with different metrics.

https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24421/6/src/osmo-bsc/abis_rsl.c@594 
PS6, Line 594: 		msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power_db / 2);
aren't you missing here the 0x10 flag?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24421
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I229db1d6bcf532af95aff56b2ad18b5ed9d81616
Gerrit-Change-Number: 24421
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 May 2021 10:33:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/c3c8c85a/attachment.htm>


More information about the gerrit-log mailing list