Change in osmo-bsc[master]: potential segfault: vty chan act: do not set AMR bits for EFR

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24393 )


Change subject: potential segfault: vty chan act: do not set AMR bits for EFR
......................................................................

potential segfault: vty chan act: do not set AMR bits for EFR

The amr_mode parameter may be passed as -1 and is directly used as an
array index in amr_modes[]. The AMR related switch case properly checks
against a -1 index, but the EFR does not -- and should not use s15_s0.

Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/24393/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index c482fb9..b964dbc 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -6078,7 +6078,6 @@
 			info = (struct lchan_activate_info) {
 				.activ_for = ACTIVATE_FOR_VTY,
 				.chan_mode = GSM48_CMODE_SPEECH_EFR,
-				.s15_s0 = amr_modes[amr_mode],
 				.requires_voice_stream = false,
 			};
 		} else if (!strcmp(codec_str, "amr")) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c
Gerrit-Change-Number: 24393
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/48858836/attachment.htm>