<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24393">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">potential segfault: vty chan act: do not set AMR bits for EFR<br><br>The amr_mode parameter may be passed as -1 and is directly used as an<br>array index in amr_modes[]. The AMR related switch case properly checks<br>against a -1 index, but the EFR does not -- and should not use s15_s0.<br><br>Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/24393/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index c482fb9..b964dbc 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -6078,7 +6078,6 @@</span><br><span>                         info = (struct lchan_activate_info) {</span><br><span>                                .activ_for = ACTIVATE_FOR_VTY,</span><br><span>                               .chan_mode = GSM48_CMODE_SPEECH_EFR,</span><br><span style="color: hsl(0, 100%, 40%);">-                            .s15_s0 = amr_modes[amr_mode],</span><br><span>                               .requires_voice_stream = false,</span><br><span>                      };</span><br><span>           } else if (!strcmp(codec_str, "amr")) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24393">change 24393</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24393"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c </div>
<div style="display:none"> Gerrit-Change-Number: 24393 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>