This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24352 ) Change subject: make sure channel mode and s15_s0 are updated only after an ACK ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c@6086 PS2, Line 6086: amr_modes[amr_mode], > Unrelated: below the 'amr_mode' is compared to -1. […] wait a minute, i thought i had a separate patch to fix this... this is a bug existing prior to this patch and i'm sure i removed that s15_s0 line in a patch, because AFAIU EFR doesn't use those bits anyway. ah found it, it got lost on another branch, will include here -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412 Gerrit-Change-Number: 24352 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 25 May 2021 14:54:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/e885b07e/attachment.htm>