This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24352 ) Change subject: make sure channel mode and s15_s0 are updated only after an ACK ...................................................................... Patch Set 2: (5 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c@6085 PS2, Line 6085: chan_t_to_chan_rate It shall always be CH_RATE_FULL for EFR, because EFR does not work on TCH/H. https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c@6086 PS2, Line 6086: amr_modes[amr_mode], Unrelated: below the 'amr_mode' is compared to -1. Should we check it here too? https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c@6109 PS2, Line 6109: CH_RATE_SDCCH Are you sure about this one? Both CH_RATE_HALF and CH_RATE_FULL can operate in signalling mode too. https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/gsm_data.c@691 PS2, Line 691: default: Cosmetic: it's unusual to see 'default' before the other 'case's. https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/gsm_data.c@692 PS2, Line 692: return -1; Callers of this function do not check the returned value, so I would rather add OSMO_ASSERT(0) here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412 Gerrit-Change-Number: 24352 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sun, 23 May 2021 17:37:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/f371f987/attachment.htm>