This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24343 ) Change subject: commands: resolve inconsistency on sel_ctrl ...................................................................... commands: resolve inconsistency on sel_ctrl The code uses self.sel_ctrl everywhere except in the two @property methods, where the _sel_ctrl variable is used. Let's just abandon those property methods and make sure all users directly use the [public] sel_ctrl member variable. Change-Id: I10362300c1cf7b493d89bf71bbd3a10c80ef9a49 --- M pySim/commands.py 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index 48c66bd..800c2dd 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -96,13 +96,6 @@ def cla_byte(self, value): self._cla_byte = value - @property - def sel_ctrl(self): - return self._sel_ctrl - @sel_ctrl.setter - def sel_ctrl(self, value): - self._sel_ctrl = value - def try_select_path(self, dir_list): """ Try to select a specified path given as list of hex-string FIDs""" rv = [] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I10362300c1cf7b493d89bf71bbd3a10c80ef9a49 Gerrit-Change-Number: 24343 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/f719640e/attachment.htm>