<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24343">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">commands: resolve inconsistency on sel_ctrl<br><br>The code uses self.sel_ctrl everywhere except in the two @property<br>methods, where the _sel_ctrl variable is used.  Let's just abandon<br>those property methods and make sure all users directly use the<br>[public] sel_ctrl member variable.<br><br>Change-Id: I10362300c1cf7b493d89bf71bbd3a10c80ef9a49<br>---<br>M pySim/commands.py<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/commands.py b/pySim/commands.py</span><br><span>index 48c66bd..800c2dd 100644</span><br><span>--- a/pySim/commands.py</span><br><span>+++ b/pySim/commands.py</span><br><span>@@ -96,13 +96,6 @@</span><br><span>     def cla_byte(self, value):</span><br><span>           self._cla_byte = value</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      @property</span><br><span style="color: hsl(0, 100%, 40%);">-       def sel_ctrl(self):</span><br><span style="color: hsl(0, 100%, 40%);">-             return self._sel_ctrl</span><br><span style="color: hsl(0, 100%, 40%);">-   @sel_ctrl.setter</span><br><span style="color: hsl(0, 100%, 40%);">-        def sel_ctrl(self, value):</span><br><span style="color: hsl(0, 100%, 40%);">-              self._sel_ctrl = value</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       def try_select_path(self, dir_list):</span><br><span>                 """ Try to select a specified path given as list of hex-string FIDs"""</span><br><span>                 rv = []</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24343">change 24343</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24343"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I10362300c1cf7b493d89bf71bbd3a10c80ef9a49 </div>
<div style="display:none"> Gerrit-Change-Number: 24343 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>