This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24011 ) Change subject: ts_31_103: finish decoder and fix encoder for EF.PCSCF ...................................................................... ts_31_103: finish decoder and fix encoder for EF.PCSCF The encoder/decoder functions in class EF_PCSCF look rather unfinshed because of problems with dec_addr_tlv(), since those problems are fixed by a previous patch we can now finish the decoder function and fix the decoder as well. Change-Id: I7613b8b71624dc5802aca93163788a2a2d4ca345 Related: OS#4963 --- M pySim/ts_31_103.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index 6224bc8..5ca8279 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -116,10 +116,12 @@ def __init__(self, fid='6f09', sfid=None, name='EF.P-CSCF', desc='P-CSCF Address'): super().__init__(fid=fid, sfid=sfid, name=name, desc=desc) def _decode_record_hex(self, raw_hex): - # FIXME: this doesn't do JSON output - return dec_addr_tlv(raw_hex) + addr, addr_type = dec_addr_tlv(raw_hex) + return {"addr": addr, "addr_type": addr_type} def _encode_record_hex(self, json_in): - return enc_addr_tlv(json_in) + addr = json_in['addr'] + addr_type = json_in['addr_type'] + return enc_addr_tlv(addr, addr_type) # TS 31.103 Section 4.2.9 class EF_GBABP(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7613b8b71624dc5802aca93163788a2a2d4ca345 Gerrit-Change-Number: 24011 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/154d5e09/attachment.htm>