<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24011">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ts_31_103: finish decoder and fix encoder for EF.PCSCF<br><br>The encoder/decoder functions in class EF_PCSCF look rather unfinshed<br>because of problems with dec_addr_tlv(), since those problems are fixed<br>by a previous patch we can now finish the decoder function and fix the<br>decoder as well.<br><br>Change-Id: I7613b8b71624dc5802aca93163788a2a2d4ca345<br>Related: OS#4963<br>---<br>M pySim/ts_31_103.py<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py</span><br><span>index 6224bc8..5ca8279 100644</span><br><span>--- a/pySim/ts_31_103.py</span><br><span>+++ b/pySim/ts_31_103.py</span><br><span>@@ -116,10 +116,12 @@</span><br><span>     def __init__(self, fid='6f09', sfid=None, name='EF.P-CSCF', desc='P-CSCF Address'):</span><br><span>         super().__init__(fid=fid, sfid=sfid, name=name, desc=desc)</span><br><span>     def _decode_record_hex(self, raw_hex):</span><br><span style="color: hsl(0, 100%, 40%);">-        # FIXME: this doesn't do JSON output</span><br><span style="color: hsl(0, 100%, 40%);">-        return dec_addr_tlv(raw_hex)</span><br><span style="color: hsl(120, 100%, 40%);">+        addr, addr_type = dec_addr_tlv(raw_hex)</span><br><span style="color: hsl(120, 100%, 40%);">+        return {"addr": addr, "addr_type": addr_type}</span><br><span>     def _encode_record_hex(self, json_in):</span><br><span style="color: hsl(0, 100%, 40%);">-        return enc_addr_tlv(json_in)</span><br><span style="color: hsl(120, 100%, 40%);">+        addr = json_in['addr']</span><br><span style="color: hsl(120, 100%, 40%);">+        addr_type = json_in['addr_type']</span><br><span style="color: hsl(120, 100%, 40%);">+        return enc_addr_tlv(addr, addr_type)</span><br><span> </span><br><span> # TS 31.103 Section 4.2.9</span><br><span> class EF_GBABP(TransparentEF):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24011">change 24011</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24011"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7613b8b71624dc5802aca93163788a2a2d4ca345 </div>
<div style="display:none"> Gerrit-Change-Number: 24011 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>