This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24135 ) Change subject: cards: populate name property in Card, UsimCard and IsimCard ...................................................................... cards: populate name property in Card, UsimCard and IsimCard Even though Card, UsimCard and IsimCard are abstract classes which are normally only used to inherit from mit may make sense to pre-populate the name property with some meaningful value. Change-Id: Id643e1f83718aea073e7200aecbf2db2def8652f --- M pySim/cards.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/cards.py b/pySim/cards.py index dcba26c..7744c7a 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -34,6 +34,8 @@ class Card(object): + name = 'SIM' + def __init__(self, scc): self._scc = scc self._adm_chv_num = 4 @@ -291,6 +293,9 @@ self._scc.update_record(ef, rec_no, "ff" * len, force_len=False, verify=True) class UsimCard(Card): + + name = 'USIM' + def __init__(self, ssc): super(UsimCard, self).__init__(ssc) @@ -361,6 +366,9 @@ return sw class IsimCard(Card): + + name = 'ISIM' + def __init__(self, ssc): super(IsimCard, self).__init__(ssc) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id643e1f83718aea073e7200aecbf2db2def8652f Gerrit-Change-Number: 24135 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/564ed416/attachment.htm>