<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24135">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cards: populate name property in Card, UsimCard and IsimCard<br><br>Even though Card, UsimCard and IsimCard are abstract classes which are<br>normally only used to inherit from mit may make sense to pre-populate<br>the name property with some meaningful value.<br><br>Change-Id: Id643e1f83718aea073e7200aecbf2db2def8652f<br>---<br>M pySim/cards.py<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index dcba26c..7744c7a 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -34,6 +34,8 @@</span><br><span> </span><br><span> class Card(object):</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ name = 'SIM'</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       def __init__(self, scc):</span><br><span>             self._scc = scc</span><br><span>              self._adm_chv_num = 4</span><br><span>@@ -291,6 +293,9 @@</span><br><span>          self._scc.update_record(ef, rec_no, "ff" * len, force_len=False, verify=True)</span><br><span> </span><br><span> class UsimCard(Card):</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        name = 'USIM'</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      def __init__(self, ssc):</span><br><span>             super(UsimCard, self).__init__(ssc)</span><br><span> </span><br><span>@@ -361,6 +366,9 @@</span><br><span>                return sw</span><br><span> </span><br><span> class IsimCard(Card):</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      name = 'ISIM'</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      def __init__(self, ssc):</span><br><span>             super(IsimCard, self).__init__(ssc)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24135">change 24135</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24135"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id643e1f83718aea073e7200aecbf2db2def8652f </div>
<div style="display:none"> Gerrit-Change-Number: 24135 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>