This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247 )
Change subject: msc: add first a5/4 tests
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247/3/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247/3/msc/BSC_ConnectionHandler.ttcn@166
PS3, Line 166: if (mask and4b ('00000001'B << whicha5) != '00000000'B) {
This could be done easier:
return mask[7 - whicha5] == '1'B;
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247/3/msc/BSC_ConnectionHandler.ttcn@572
PS3, Line 572:
No need to change spacing here, it's similar to switch() in C.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idc055a006b325f58a5eafa88bc4415181b3500a2
Gerrit-Change-Number: 24247
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 May 2021 23:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210517/0f2149fc/attachment.htm>