<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247/3/msc/BSC_ConnectionHandler.ttcn">File msc/BSC_ConnectionHandler.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247/3/msc/BSC_ConnectionHandler.ttcn@166">Patch Set #3, Line 166:</a> <code style="font-family:monospace,monospace"> if (mask and4b ('00000001'B << whicha5) != '00000000'B) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This could be done easier:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  return mask[7 - whicha5] == '1'B;</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247/3/msc/BSC_ConnectionHandler.ttcn@572">Patch Set #3, Line 572:</a> <code style="font-family:monospace,monospace">     </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No need to change spacing here, it's similar to switch() in C.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247">change 24247</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24247"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idc055a006b325f58a5eafa88bc4415181b3500a2 </div>
<div style="display:none"> Gerrit-Change-Number: 24247 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 May 2021 23:50:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>