Change in libosmo-sccp[master]: sccp_scrc: Ensure we have not just SSN but at least OPC+SSN in Callin...

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/24218 )

Change subject: sccp_scrc: Ensure we have not just SSN but at least OPC+SSN in CallingParty
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/24218/2/src/sccp_scrc.c 
File src/sccp_scrc.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/24218/2/src/sccp_scrc.c@453 
PS2, Line 453: 	    calling.presence == OSMO_SCCP_ADDR_T_SSN) {
> shouldn't you simply check && !(calling. […]
the condition is if there is _only_ a SSN present (see '==' above).  That implies that "presence & OSMO_SCCP_ADDR_T_PC" is false.


https://gerrit.osmocom.org/c/libosmo-sccp/+/24218/2/src/sccp_scrc.c@486 
PS2, Line 486: 	/* ensure we have at least OPC+SSN and not just SSN in CallingParty (OS#5146) */
> Why is the comment here and not above ensure_opc_in_calling_ssn()?
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/24218
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Id66ae960ebe3cb3b09c6dd5454f9ac9c073f46d7
Gerrit-Change-Number: 24218
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 13 May 2021 19:25:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210513/730827f1/attachment.htm>