This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/24218 )
Change subject: sccp_scrc: Ensure we have not just SSN but at least OPC+SSN in CallingParty
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/libosmo-sccp/+/24218/2/src/sccp_scrc.c
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/24218/2/src/sccp_scrc.c@453
PS2, Line 453: calling.presence == OSMO_SCCP_ADDR_T_SSN) {
shouldn't you simply check && !(calling.presence & OSMO_SCCP_ADDR_T_PC) here, and then you don't need to enter the block and call xua_msg_free_tag()?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/24218
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Id66ae960ebe3cb3b09c6dd5454f9ac9c073f46d7
Gerrit-Change-Number: 24218
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 May 2021 11:41:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210512/825be82c/attachment.htm>