This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24157 ) Change subject: ModemATCommandLink: add/adjust some logging ...................................................................... ModemATCommandLink: add/adjust some logging Change-Id: I303506a751b4a34d83c18bc097e0cfb0517ee82c --- M pySim/transport/modem_atcmd.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index bb23ce9..3d39a20 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -71,10 +71,10 @@ log.debug('Command finished with result: OK') break if rsp.endswith(b'ERROR\r\n'): - log.debug('Command finished with result: ERROR') + log.error('Command finished with result: ERROR') break if time.time() - t_start >= timeout: - log.debug('Command finished with timeout >= %ss', timeout) + log.info('Command finished with timeout >= %ss', timeout) break time.sleep(patience) its += 1 @@ -137,6 +137,7 @@ # Prepare the command as described in 8.17 cmd = 'AT+CSIM=%d,\"%s\"' % (len(pdu), pdu) + log.debug('Sending command: %s', cmd) # Send AT+CSIM command to the modem # TODO: also handle +CME ERROR: <err> @@ -155,4 +156,5 @@ # TODO: make sure we have at least SW data = rsp_pdu[:-4].decode().lower() sw = rsp_pdu[-4:].decode().lower() + log.debug('Command response: %s, %s', data, sw) return data, sw -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I303506a751b4a34d83c18bc097e0cfb0517ee82c Gerrit-Change-Number: 24157 Gerrit-PatchSet: 3 Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210507/183ac968/attachment.htm>