<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24157">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ModemATCommandLink: add/adjust some logging<br><br>Change-Id: I303506a751b4a34d83c18bc097e0cfb0517ee82c<br>---<br>M pySim/transport/modem_atcmd.py<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py</span><br><span>index bb23ce9..3d39a20 100644</span><br><span>--- a/pySim/transport/modem_atcmd.py</span><br><span>+++ b/pySim/transport/modem_atcmd.py</span><br><span>@@ -71,10 +71,10 @@</span><br><span>                              log.debug('Command finished with result: OK')</span><br><span>                                break</span><br><span>                        if rsp.endswith(b'ERROR\r\n'):</span><br><span style="color: hsl(0, 100%, 40%);">-                          log.debug('Command finished with result: ERROR')</span><br><span style="color: hsl(120, 100%, 40%);">+                              log.error('Command finished with result: ERROR')</span><br><span>                             break</span><br><span>                        if time.time() - t_start >= timeout:</span><br><span style="color: hsl(0, 100%, 40%);">-                         log.debug('Command finished with timeout >= %ss', timeout)</span><br><span style="color: hsl(120, 100%, 40%);">+                         log.info('Command finished with timeout >= %ss', timeout)</span><br><span>                                 break</span><br><span>                        time.sleep(patience)</span><br><span>                         its += 1</span><br><span>@@ -137,6 +137,7 @@</span><br><span> </span><br><span>           # Prepare the command as described in 8.17</span><br><span>           cmd = 'AT+CSIM=%d,\"%s\"' % (len(pdu), pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+         log.debug('Sending command: %s',  cmd)</span><br><span> </span><br><span>           # Send AT+CSIM command to the modem</span><br><span>          # TODO: also handle +CME ERROR: <err></span><br><span>@@ -155,4 +156,5 @@</span><br><span>            # TODO: make sure we have at least SW</span><br><span>                data = rsp_pdu[:-4].decode().lower()</span><br><span>                 sw   = rsp_pdu[-4:].decode().lower()</span><br><span style="color: hsl(120, 100%, 40%);">+          log.debug('Command response: %s, %s',  data, sw)</span><br><span>             return data, sw</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24157">change 24157</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24157"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I303506a751b4a34d83c18bc097e0cfb0517ee82c </div>
<div style="display:none"> Gerrit-Change-Number: 24157 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Falkenber9 <robert.falkenberg@tu-dortmund.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>