This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgHello osmith, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/23303 to look at the new patch set (#4). Change subject: Make respawn.sh a common part of *-build/-obs images ...................................................................... Make respawn.sh a common part of *-build/-obs images Maintaining several versions of the same file in different folders is a bad idea, because at some point their content gets out of sync. This is exactly what happened to 'respawn.sh': sleep()ing was only implemented in 'osmo-bts-master/respawn.sh', other versions of this file would simply ignore '$SLEEP_BEFORE_RESPAWN'. The easiest solution would be to have all common files in a single directory, however Docker does not allow to ADD files from outside of the build context. In other words, all files must be in the same directory as the Dockerfile itself. Modify 'make/Makefile' in order to copy the contents of common directory to the current build context ('pre-build' target) and remove it after building ('post-build' target). Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e --- M .gitignore M centos8-build/Dockerfile M centos8-obs-latest/Dockerfile R common/respawn.sh M debian-buster-build/Dockerfile M debian-jessie-build/Dockerfile M debian-sid-build/Dockerfile M debian-stretch-obs-latest/Dockerfile M make/Makefile M osmo-bts-latest/Dockerfile D osmo-bts-latest/respawn.sh M osmo-bts-master/Dockerfile M osmo-pcu-latest/Dockerfile D osmo-pcu-latest/respawn.sh M osmo-pcu-master/Dockerfile D osmo-pcu-master/respawn.sh 16 files changed, 22 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/23303/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e Gerrit-Change-Number: 23303 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210310/e3396c18/attachment.htm>