<p>fixeria <strong>uploaded patch set #4</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23303">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Make respawn.sh a common part of *-build/-obs images<br><br>Maintaining several versions of the same file in different folders<br>is a bad idea, because at some point their content gets out of sync.<br>This is exactly what happened to 'respawn.sh': sleep()ing was only<br>implemented in 'osmo-bts-master/respawn.sh', other versions of this<br>file would simply ignore '$SLEEP_BEFORE_RESPAWN'.<br><br>The easiest solution would be to have all common files in a single<br>directory, however Docker does not allow to ADD files from outside<br>of the build context.  In other words, all files must be in the<br>same directory as the Dockerfile itself.<br><br>Modify 'make/Makefile' in order to copy the contents of common<br>directory to the current build context ('pre-build' target) and<br>remove it after building ('post-build' target).<br><br>Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e<br>---<br>M .gitignore<br>M centos8-build/Dockerfile<br>M centos8-obs-latest/Dockerfile<br>R common/respawn.sh<br>M debian-buster-build/Dockerfile<br>M debian-jessie-build/Dockerfile<br>M debian-sid-build/Dockerfile<br>M debian-stretch-obs-latest/Dockerfile<br>M make/Makefile<br>M osmo-bts-latest/Dockerfile<br>D osmo-bts-latest/respawn.sh<br>M osmo-bts-master/Dockerfile<br>M osmo-pcu-latest/Dockerfile<br>D osmo-pcu-latest/respawn.sh<br>M osmo-pcu-master/Dockerfile<br>D osmo-pcu-master/respawn.sh<br>16 files changed, 22 insertions(+), 53 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/23303/4</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/23303">change 23303</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/23303"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e </div>
<div style="display:none"> Gerrit-Change-Number: 23303 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>