Change in simtrace2[master]: Introduce simtrace2-tool

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24574 )

Change subject: Introduce simtrace2-tool
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c 
File host/src/simtrace2-tool.c:

https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@261 
PS1, Line 261: 	if ((vendor_id < 0 || product_id < 0)) {
why ((?


https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@293 
PS1, Line 293: 			rc = libusb_claim_interface(transp->usb_devh, if_num);
why is this needed? I would expect "osmo_libusb_open_claim_interface" to claim it already


https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@322 
PS1, Line 322: 1
Doesn't make much difference, but I'm wondering: why not pass rc here?



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3a8896ac2b3caef7590b51118359e5caed820a40
Gerrit-Change-Number: 24574
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Jun 2021 16:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210608/31c3ffd4/attachment.htm>