<p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24574">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c">File host/src/simtrace2-tool.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@261">Patch Set #1, Line 261:</a> <code style="font-family:monospace,monospace">     if ((vendor_id < 0 || product_id < 0)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why ((?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@293">Patch Set #1, Line 293:</a> <code style="font-family:monospace,monospace">                  rc = libusb_claim_interface(transp->usb_devh, if_num);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why is this needed? I would expect "osmo_libusb_open_claim_interface" to claim it already</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@322">Patch Set #1, Line 322:</a> <code style="font-family:monospace,monospace">1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Doesn't make much difference, but I'm wondering: why not pass rc here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/24574">change 24574</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/24574"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3a8896ac2b3caef7590b51118359e5caed820a40 </div>
<div style="display:none"> Gerrit-Change-Number: 24574 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 08 Jun 2021 16:31:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>