This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25083 ) Change subject: firmware: make the ngff beakout blink ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/simtrace2/+/25083/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/25083/4//COMMIT_MSG@8 PS4, Line 8: I'd mention that it blinks now when switching to remote/emulated SIM. https://gerrit.osmocom.org/c/simtrace2/+/25083/4/firmware/libboard/common/include/led.h File firmware/libboard/common/include/led.h: https://gerrit.osmocom.org/c/simtrace2/+/25083/4/firmware/libboard/common/include/led.h@34 PS4, Line 34: BLINK_2F_O = 10, can you throw in some tabs to indent it like the line above? https://gerrit.osmocom.org/c/simtrace2/+/25083/4/firmware/libboard/common/include/led.h@35 PS4, Line 35: BLINK_5O_5F, why is this not = 11? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I65f1fbeb06690a143ef4c792728c9cb917a4ffde Gerrit-Change-Number: 25083 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jul 2021 09:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/4548eec1/attachment.htm>