Change in simtrace2[master]: firmware: make the ngff beakout blink

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Wed Jul 28 13:46:49 UTC 2021


Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/25083 )


Change subject: firmware: make the ngff beakout blink
......................................................................

firmware: make the ngff beakout blink

Change-Id: I65f1fbeb06690a143ef4c792728c9cb917a4ffde
---
M firmware/libboard/common/include/led.h
M firmware/libboard/common/source/led.c
M firmware/libboard/ngff_cardem/source/sim_switch.c
3 files changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/83/25083/1

diff --git a/firmware/libboard/common/include/led.h b/firmware/libboard/common/include/led.h
index 339702d..9283989 100644
--- a/firmware/libboard/common/include/led.h
+++ b/firmware/libboard/common/include/led.h
@@ -31,7 +31,8 @@
 	BLINK_200O_F		= 7,
 	BLINK_600O_F		= 8,
 	BLINK_CUSTOM		= 9,
-	BLINK_2F_O,
+	BLINK_2F_O = 10,
+	BLINK_5O_5F,
 	_NUM_LED_BLINK
 };
 
diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c
index 6772007..4822a6d 100644
--- a/firmware/libboard/common/source/led.c
+++ b/firmware/libboard/common/source/led.c
@@ -58,6 +58,10 @@
 	{ 0, 1 }
 };
 
+static const struct blink_state bs_5on_5off[] = {
+	{ 500, 1 }, { 500, 0 }
+};
+
 static const struct blink_state bs_3on_5off[] = {
 	{ 300, 1 }, { 500, 0 }
 };
@@ -107,6 +111,10 @@
 		.states = bs_on,
 		.size = ARRAY_SIZE(bs_on),
 	},
+	[BLINK_5O_5F] = {
+		.states = bs_5on_5off,
+		.size = ARRAY_SIZE(bs_5on_5off),
+	},
 	[BLINK_3O_5F] = {
 		.states = bs_3on_5off,
 		.size = ARRAY_SIZE(bs_3on_5off),
diff --git a/firmware/libboard/ngff_cardem/source/sim_switch.c b/firmware/libboard/ngff_cardem/source/sim_switch.c
index 3961747..b841e25 100644
--- a/firmware/libboard/ngff_cardem/source/sim_switch.c
+++ b/firmware/libboard/ngff_cardem/source/sim_switch.c
@@ -83,7 +83,7 @@
 	} else {
 		TRACE_INFO("%u: Use remote/emulated SIM\r\n", nr);
 		PIO_Configure(pins_cem, PIO_LISTSIZE(pins_cem));
-		led_blink(led, BLINK_ALWAYS_OFF);
+		led_blink(led, BLINK_5O_5F);
 	}
 
 	/* just power cycle the modem because this circumvents weird issues with unreliable signals */

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25083
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I65f1fbeb06690a143ef4c792728c9cb917a4ffde
Gerrit-Change-Number: 25083
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210728/dc3f0641/attachment.htm>


More information about the gerrit-log mailing list