This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25082 ) Change subject: introduce support for new ngff_cardem board ...................................................................... Patch Set 4: (5 comments) the code is very readable! only found some cosmetics. https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/include/board.h File firmware/libboard/ngff_cardem/include/board.h: https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/include/board.h@145 PS4, Line 145: default state "cardem state" https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c File firmware/libboard/ngff_cardem/source/board_ngff_cardem.c: https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c@1 PS4, Line 1: /* sysmocom quad-modem sysmoQMOD application code * not adjusted to ngff_cardem board * README.txt also doesn't mention the new board yet https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c@45 PS4, Line 45: printf("\tU\tProceed to USB Initialization\n\r"); 'U' not implemented below? same with '@' Looks like they are not meant to be implemented as part of this patch, so I'd remove them (or comment them out). https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c@98 PS4, Line 98: (missing ) ) https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/wwan_led.c File firmware/libboard/ngff_cardem/source/wwan_led.c: https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/wwan_led.c@50 PS4, Line 50: /* determine if a tiven WWAN led is currently active or not */ tiven -> given -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ia96124fbe8a752c98e7fd4096d542a3b2b9bc255 Gerrit-Change-Number: 25082 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jul 2021 09:09:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/913a0b88/attachment.htm>