<p style="white-space: pre-wrap; word-wrap: break-word;">the code is very readable! only found some cosmetics.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/include/board.h">File firmware/libboard/ngff_cardem/include/board.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/include/board.h@145">Patch Set #4, Line 145:</a> <code style="font-family:monospace,monospace">default state</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"cardem state"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c">File firmware/libboard/ngff_cardem/source/board_ngff_cardem.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c@1">Patch Set #4, Line 1:</a> <code style="font-family:monospace,monospace">/* sysmocom quad-modem sysmoQMOD application code</code></p><ul><li>not adjusted to ngff_cardem board</li><li>README.txt also doesn't mention the new board yet</li></ul></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c@45">Patch Set #4, Line 45:</a> <code style="font-family:monospace,monospace">             printf("\tU\tProceed to USB Initialization\n\r");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'U' not implemented below? same with '@'</p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks like they are not meant to be implemented as part of this patch, so I'd remove them (or comment them out).</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c@98">Patch Set #4, Line 98:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">(missing ) )</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/wwan_led.c">File firmware/libboard/ngff_cardem/source/wwan_led.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/25082/4/firmware/libboard/ngff_cardem/source/wwan_led.c@50">Patch Set #4, Line 50:</a> <code style="font-family:monospace,monospace">/* determine if a tiven WWAN led is currently active or not */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">tiven -> given</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/25082">change 25082</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/25082"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia96124fbe8a752c98e7fd4096d542a3b2b9bc255 </div>
<div style="display:none"> Gerrit-Change-Number: 25082 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Jul 2021 09:09:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>