This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24945 ) Change subject: mgcp_client: add logging on received MGCP messages ...................................................................... mgcp_client: add logging on received MGCP messages There is verbose debug logging on MGCP messages sent out to the MGW, but none on received MGCP messages. Add Rx logging. Related: SYS#5529 Change-Id: Id76230896aa87c1a12bd5ad87a62430c048a2873 --- M src/libosmo-mgcp-client/mgcp_client.c M tests/mgcp_client/mgcp_client_test.err 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 8e6780e..9d60ee8 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -677,6 +677,9 @@ goto error; } + LOGP(DLMGCP, LOGL_DEBUG, "MGCP client: Rx %d %u %s\n", + r->head.response_code, r->head.trans_id, r->head.comment); + rc = parse_head_params(r); if (rc) { LOGP(DLMGCP, LOGL_ERROR, "Cannot parse MGCP response (head parameters)\n"); diff --git a/tests/mgcp_client/mgcp_client_test.err b/tests/mgcp_client/mgcp_client_test.err index 80119cb..e7db23c 100644 --- a/tests/mgcp_client/mgcp_client_test.err +++ b/tests/mgcp_client/mgcp_client_test.err @@ -10,6 +10,7 @@ - cancel succeeds DLMGCP Canceled transaction 1 - late response gets discarded +DLMGCP MGCP client: Rx 200 1 OK DLMGCP Cannot find matching MGCP transaction for trans_id 1 - canceling again does nothing DLMGCP Cannot cancel, no such transaction: 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id76230896aa87c1a12bd5ad87a62430c048a2873 Gerrit-Change-Number: 24945 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210716/194e7860/attachment.htm>