<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24945">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_client: add logging on received MGCP messages<br><br>There is verbose debug logging on MGCP messages sent out to the MGW, but<br>none on received MGCP messages. Add Rx logging.<br><br>Related: SYS#5529<br>Change-Id: Id76230896aa87c1a12bd5ad87a62430c048a2873<br>---<br>M src/libosmo-mgcp-client/mgcp_client.c<br>M tests/mgcp_client/mgcp_client_test.err<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>index 8e6780e..9d60ee8 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client.c</span><br><span>@@ -677,6 +677,9 @@</span><br><span>                 goto error;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DLMGCP, LOGL_DEBUG, "MGCP client: Rx %d %u %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           r->head.response_code, r->head.trans_id, r->head.comment);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   rc = parse_head_params(r);</span><br><span>   if (rc) {</span><br><span>            LOGP(DLMGCP, LOGL_ERROR, "Cannot parse MGCP response (head parameters)\n");</span><br><span>diff --git a/tests/mgcp_client/mgcp_client_test.err b/tests/mgcp_client/mgcp_client_test.err</span><br><span>index 80119cb..e7db23c 100644</span><br><span>--- a/tests/mgcp_client/mgcp_client_test.err</span><br><span>+++ b/tests/mgcp_client/mgcp_client_test.err</span><br><span>@@ -10,6 +10,7 @@</span><br><span> - cancel succeeds</span><br><span> DLMGCP Canceled transaction 1</span><br><span> - late response gets discarded</span><br><span style="color: hsl(120, 100%, 40%);">+DLMGCP MGCP client: Rx 200 1 OK</span><br><span> DLMGCP Cannot find matching MGCP transaction for trans_id 1</span><br><span> - canceling again does nothing</span><br><span> DLMGCP Cannot cancel, no such transaction: 1</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24945">change 24945</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/24945"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id76230896aa87c1a12bd5ad87a62430c048a2873 </div>
<div style="display:none"> Gerrit-Change-Number: 24945 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>