Change in libosmocore[master]: gprs_ns2: introduce gprs_ns2_vty_init_reduced() for the PCU

[lynxis lazus]

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22508 )

Change subject: gprs_ns2: introduce gprs_ns2_vty_init_reduced() for the PCU
......................................................................

gprs_ns2: introduce gprs_ns2_vty_init_reduced() for the PCU

The gprs_ns2_vty_init_reduced() call initialized the ns2 vty without
configuration nodes (except timeout). The PCU can be only configured
by the BTS/BSC. It should not configured by vty.

Change-Id: I4437da74bd48ba64d3f16ea67afc26c45b6d3ac9
---
M src/gb/gprs_ns2_vty.c
M src/gb/libosmogb.map
2 files changed, 17 insertions(+), 1 deletion(-)

Approvals:
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index b6ae5b4..9db8173 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -1617,7 +1617,12 @@
 	return CMD_SUCCESS;
 }
 
-int gprs_ns2_vty_init(struct gprs_ns2_inst *nsi)
+/*! initialized a reduced vty interface which excludes the configuration nodes besides timeouts.
+ *  This can be used by the PCU which can be only configured by the BTS/BSC and not by the vty.
+ * \param[in] nsi NS instance on which we operate
+ * \return 0 on success.
+ */
+int gprs_ns2_vty_init_reduced(struct gprs_ns2_inst *nsi)
 {
 	vty_nsi = nsi;
 	INIT_LLIST_HEAD(&binds);
@@ -1645,6 +1650,16 @@
 	install_node(&ns_node, config_write_ns);
 	/* TODO: convert into osmo timer */
 	install_lib_element(L_NS_NODE, &cfg_ns_timer_cmd);
+
+	return 0;
+}
+
+int gprs_ns2_vty_init(struct gprs_ns2_inst *nsi)
+{
+	int rc = gprs_ns2_vty_init_reduced(nsi);
+	if (rc)
+		return rc;
+
 	install_lib_element(L_NS_NODE, &cfg_ns_nsei_cmd);
 	install_lib_element(L_NS_NODE, &cfg_no_ns_nsei_cmd);
 	install_lib_element(L_NS_NODE, &cfg_ns_bind_cmd);
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index 71be117..a3171d0 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -185,6 +185,7 @@
 gprs_ns2_sns_add_endpoint;
 gprs_ns2_sns_del_endpoint;
 gprs_ns2_vty_init;
+gprs_ns2_vty_init_reduced;
 
 gprs_nsvc_create2;
 gprs_nsvc_delete;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4437da74bd48ba64d3f16ea67afc26c45b6d3ac9
Gerrit-Change-Number: 22508
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210128/397238c9/attachment.htm>