<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22508">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: introduce gprs_ns2_vty_init_reduced() for the PCU<br><br>The gprs_ns2_vty_init_reduced() call initialized the ns2 vty without<br>configuration nodes (except timeout). The PCU can be only configured<br>by the BTS/BSC. It should not configured by vty.<br><br>Change-Id: I4437da74bd48ba64d3f16ea67afc26c45b6d3ac9<br>---<br>M src/gb/gprs_ns2_vty.c<br>M src/gb/libosmogb.map<br>2 files changed, 17 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index b6ae5b4..9db8173 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -1617,7 +1617,12 @@</span><br><span>       return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int gprs_ns2_vty_init(struct gprs_ns2_inst *nsi)</span><br><span style="color: hsl(120, 100%, 40%);">+/*! initialized a reduced vty interface which excludes the configuration nodes besides timeouts.</span><br><span style="color: hsl(120, 100%, 40%);">+ *  This can be used by the PCU which can be only configured by the BTS/BSC and not by the vty.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] nsi NS instance on which we operate</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return 0 on success.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+int gprs_ns2_vty_init_reduced(struct gprs_ns2_inst *nsi)</span><br><span> {</span><br><span>     vty_nsi = nsi;</span><br><span>       INIT_LLIST_HEAD(&binds);</span><br><span>@@ -1645,6 +1650,16 @@</span><br><span>        install_node(&ns_node, config_write_ns);</span><br><span>         /* TODO: convert into osmo timer */</span><br><span>  install_lib_element(L_NS_NODE, &cfg_ns_timer_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int gprs_ns2_vty_init(struct gprs_ns2_inst *nsi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   int rc = gprs_ns2_vty_init_reduced(nsi);</span><br><span style="color: hsl(120, 100%, 40%);">+      if (rc)</span><br><span style="color: hsl(120, 100%, 40%);">+               return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         install_lib_element(L_NS_NODE, &cfg_ns_nsei_cmd);</span><br><span>        install_lib_element(L_NS_NODE, &cfg_no_ns_nsei_cmd);</span><br><span>     install_lib_element(L_NS_NODE, &cfg_ns_bind_cmd);</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index 71be117..a3171d0 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -185,6 +185,7 @@</span><br><span> gprs_ns2_sns_add_endpoint;</span><br><span> gprs_ns2_sns_del_endpoint;</span><br><span> gprs_ns2_vty_init;</span><br><span style="color: hsl(120, 100%, 40%);">+gprs_ns2_vty_init_reduced;</span><br><span> </span><br><span> gprs_nsvc_create2;</span><br><span> gprs_nsvc_delete;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22508">change 22508</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22508"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4437da74bd48ba64d3f16ea67afc26c45b6d3ac9 </div>
<div style="display:none"> Gerrit-Change-Number: 22508 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>