This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22383 ) Change subject: gprs_pcu: Use libosmocore osmo_cgi_ps_cmp API ...................................................................... gprs_pcu: Use libosmocore osmo_cgi_ps_cmp API it was noticed that gprs_pcu_get_bts_by_cgi_ps() sometimes failed to return the BTS even if the CGI-PS fields matched, probably due to memcmp checking too padding bytes which may not be zero-initialized in one of the two memory regions being checked. Let's be on the safe side and use libosmocore APIs to check them. Depends: libosmocore.git Change-Id I00e329bc5be8674b30267dec238e7656ddfc21db Change-Id: I7c8ee2c447634e45b367bb8f84adf0140ae48591 --- M src/gprs_pcu.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 32259b8..2f18dfd 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -120,7 +120,7 @@ { struct gprs_rlcmac_bts *pos; llist_for_each_entry(pos, &pcu->bts_list, list) { - if (memcmp(&pos->cgi_ps, cgi_ps, sizeof(*cgi_ps)) == 0) + if (osmo_cgi_ps_cmp(&pos->cgi_ps, cgi_ps) == 0) return pos; } return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7c8ee2c447634e45b367bb8f84adf0140ae48591 Gerrit-Change-Number: 22383 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/c12ce3d8/attachment.htm>